Skip to content
Snippets Groups Projects

Refactored ListScheduler, made it non-abstract and added better checks to...

Merged Simon Bjurek requested to merge refactor-list-scheduler into master
2 unresolved threads
  • Refactored ListScheduler by breaking into sub-functions.
  • Made ListScheduler non-abstract since one may want to provide custom sorting indicies.
  • Added better checks to compare recreated SFG with original SFG in tests.
  • Converted iteration period bound return type to Fraction
Edited by Simon Bjurek

Merge request reports

Pipeline #158282 passed

Pipeline passed for c0dc4686 on refactor-list-scheduler

Test coverage 78.00% (-1.00%) from 8 jobs
Approval is optional

Merged by Oscar GustafssonOscar Gustafsson 2 weeks ago (Mar 10, 2025 8:27am UTC)

Merge details

  • Changes merged into master with e4fb4668 (commits were squashed).
  • Deleted the source branch.

Pipeline #158287 passed

Pipeline passed for e4fb4668 on master

Test coverage 78.00% (-1.00%) from 8 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
1825 1825 if number_of_t_in_loop in (0, 1):
1826 1826 t_l_values.append(time_of_loop)
1827 1827 else:
1828 t_l_values.append(time_of_loop / number_of_t_in_loop)
1828 t_l_values.append(ceil(time_of_loop / number_of_t_in_loop))
  • Simon Bjurek changed the description

    changed the description

  • 178 178 cyclic : bool | None, optional
    179 179 If the scheduler is allowed to schedule cyclically (modulo), by default False
    180 180 sort_order : tuple[tuple[int, bool]]
    181 Specifies which columns in the priority table to sort on and in which order, where True is ascending order.
    181 Specifies which columns in the priority table to sort on and in
    182 which order, where True is ascending order.
  • Simon Bjurek added 1 commit

    added 1 commit

    • 130ea10c - fixes from MR + inactivated failing GUI test as of now

    Compare with previous version

  • Simon Bjurek added 1 commit

    added 1 commit

    • c0dc4686 - fixes from MR + inactivated failing GUI test as of now

    Compare with previous version

  • Simon Bjurek changed the description

    changed the description

  • Oscar Gustafsson approved this merge request

    approved this merge request

  • Simon Bjurek mentioned in issue #314

    mentioned in issue #314

  • Please register or sign in to reply
    Loading