Add a sink operation to avoid dangling nodes

Closes #132 (closed)

Adds a sink operation

No tests were added because I didn't think there was a nice way to test something that does "nothing".

added Operations Signal flow graph labels

changed title from Resolve "Add a sink operation to avoid dangling nodes?" to Add a sink operation to avoid dangling nodes

changed the description

This will error? Not sure what the correct thing to do is though... Maybe raise a more explicit error? (As I do not think that this will ever be evaluated.)

Right. I suppose just throwing a NotImplementedError would be easiest

changed this line in version 2 of the diff

Probably this can be hardcoded to a suitable value (like 0).

The latency is kind of hard-coded to 0 already since the constructor sets the latency_offsets to {'in0': 0}. However the code may be more readable if the latency function explicitly always returns 0.

I think this is a good start. It should ideally be removed from schedules etc, but that can go in a later MR.

Btw, I think a suitable test may be like a two-port adaptor or a butterfly, where only one output is connected to an Output and the other to a Sink. Then check that an SFG can be created and that it only has one output etc. (Not sure that it errors currently if not both outputs are connected, but it should ideally...)

added 4 commits

• 53ab8d10 - add simple way to insert delays
• 416dcf82 - Improve Winograd examples slighlty
• af0213db - Documentation fixes
• a0edea7c - raise exception for Sink.evaluate() and add simple test

Compare with previous version

approved this merge request

added 6 commits

• a0edea7c...ce58bd0e - 3 commits from branch master
• 8ea707df - add sink operation
• dead8fed - fix pipeline error
• 4f48765e - raise exception for Sink.evaluate() and add simple test

Compare with previous version

merged