Operation Splitting

Description of issue:

Given an custom operation, then the user has defined what operation this superoperation consists of. The function should be able to split this superoperation into it's component operations.

Linked Requirements:

( 12 )

Potential Issues:

None

Blockers:

( #2 (closed), #3 (closed) )

Issue Requirements:

1. Replaces the original operation in the graph with smaller operations.

Comment:

None

added 1 deleted label

changed the description

changed the description

changed title from Stöd för split-operation to Operation Splitting

changed the description

mentioned in issue #16

added 1 deleted label

added 1 deleted label

assigned to @raska119

User story: As an ASIC-programmer I want to be able to split my custom operation into it's component operations to rebuild it with different component operations.

added 1 deleted label and removed 1 deleted label

I think it would be great if you tried to define how this splitting is supposed to work, either as a user story or just a general comment. Is the user supposed to define the components of the operation or is it going to happen automatically somehow?

changed milestone to %Period 1 Kanban

I think it would be fitting if the custom operation split automatically into its components. The user calls Split and it should return all of the Superoperation's component operations. Depending on how the Superoperation is defined I would say the signals could still be attached to the respective component operations, which means the user does not have to reattach the signals manually.

Isn't the custom operation basically a SFG, so the connections could be preserved by just iterating over the components of the SFG and extract the operations.

Yeah that makes sense

Please add a user story from the perspective of the user, like "As a user I want to be able to split an custom operation and the resulting operations should preserve the connections between the operations.". Then the user stories should be good.

As a SFG programmer I want to be able to split a custom operation into its component operations with the signals preserved, meaning they are still connected to respective operations.

created branch 6-operation-splitting to address this issue

added Needs testing label and removed 1 deleted label

Can you do some sort of quick time estimation for this issue?

changed time estimate to 1d 2h

changed milestone to %Period 2 Kanban

What is the status on this issue? @raska119

Close to figuring out how to implement the code and going to write some tests beforehand. Perhaphs 20% done?

Alright, remember to update the time tracking and ask for help if you need it.

added 1d 3h of time spent at 2020-04-22

Have implemented but not tested issue. Kind of mixed up the TDD-focus we have by implementing first, but needed serious help understanding code so it kind of got implemented along the way. Will write tests cases and security measures now. 70% done

added 1h of time spent at 2020-04-23

added 5h 30m of time spent at 2020-04-25

mentioned in merge request !34 (merged)

added Needs review label and removed Needs testing label

created branch 6-operation-splitting-2 to address this issue

added 5h of time spent at 2020-04-26

added 1 deleted label and removed Needs review label

closed

removed 1 deleted label

added 1 deleted label