Resolve #1 "Port Interface", #8 "Port Coupling" (!9) · Merge requests · Computer Engineering / B-ASIC - Better ASIC Toolbox · GitLab

Snippets Groups Projects

Merged Resolve #1 "Port Interface", #8 "Port Coupling"

1-port-interface into develop

1 unresolved thread

Merged Angus Lothian requested to merge 1-port-interface into develop 5 years ago

1 unresolved thread

Adds:

Port interface functions for InputPort and OutputPort.
Functionality for connecting ports and signals, both via signals and ports.
Tests that verifies that the functionality has been correctly implemented.
Fixes to older code so that it works with the new interfaces.
Minor functionality for connecting operations in their constructors.

Closes #1 (closed) and closes #8 (closed)

Edited 5 years ago by Angus Lothian

Activity

Angus Lothian changed milestone to %Sprint 1 5 years ago

changed milestone to %Sprint 1
Angus Lothian added Needs testing + 1 deleted label 5 years ago

added Needs testing + 1 deleted label
Angus Lothian changed the description 5 years ago

changed the description
Angus Lothian mentioned in issue #1 (closed) 5 years ago

mentioned in issue #1 (closed)
Angus Lothian mentioned in issue #8 (closed) 5 years ago

mentioned in issue #8 (closed)
Jacob Wahlman @jacwa448 started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Jacob Wahlman
Last reply by Angus Lothian 5 years ago

Jacob Wahlman @jacwa448 started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Jacob Wahlman

Jacob Wahlman @jacwa448 started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Jacob Wahlman

Jacob Wahlman @jacwa448 started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Jacob Wahlman

Jacob Wahlman @jacwa448 started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Jacob Wahlman

Jacob Wahlman @jacwa448 started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Jacob Wahlman

Jacob Wahlman @jacwa448 started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Jacob Wahlman

Jacob Wahlman added label and removed label 5 years ago

added Needs review label and removed Needs testing label

Angus Lothian added 1 commit 5 years ago

added 1 commit

ebad7458 - Add fixes to pull request comments.

Compare with previous version

Angus Lothian added 1 commit 5 years ago

added 1 commit

cdea823f - Add fix to minor error that caused pipeline fail

Compare with previous version

Kevin Scott @kevsc634 started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Kevin Scott

Ivar Härnqvist @ivaha717 started a thread on an old version of the diff 5 years ago

b_asic/port.py

         self._operation = operation
     @property
     def identifier(self) -> PortId:
         """Get the unique identifier."""
     def id(self) -> PortId:
         """Returns the unique portid."""

Kevin Scott added 1 commit 5 years ago

added 1 commit

57284d79 - refactored test cases in port and removed conftest.py

Compare with previous version

Jacob Wahlman approved this merge request 5 years ago

approved this merge request

Angus Lothian added 5 commits 5 years ago

added 5 commits

463bdebd - Change tempus of comments from gets to get
ba7ea8e7 - Change tempus of comments from gets to get in signal.py
217aa985 - Change tempus of comments from gets to get in graph component, abstract graph component, sfg
9cfb6c72 - Remove signal function has source, has destination, and port is source / destination
531e1ec7 - Merge branch '1-port-interface' of gitlab.liu.se:PUM_TDDD96/B-ASIC into 1-port-interface

Compare with previous version

Toggle commit list

Angus Lothian @anglo547 · 5 years ago

Author Contributor

@jacwa448 and @ivaha717 please approve / review for merge.

Jacob Wahlman approved this merge request 5 years ago

approved this merge request

Ivar Härnqvist approved this merge request 5 years ago

approved this merge request

Ivar Härnqvist merged 5 years ago

merged

Ivar Härnqvist mentioned in commit 5 years ago

mentioned in commit 24120414

Please register or sign in to reply