Skip to content
Snippets Groups Projects

Add direct form iir sfg gen

Merged Simon Bjurek requested to merge add-direct-form-iir-sfg-gen into master

Closes #274 (closed)

Edited by Simon Bjurek

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 255 255 output <<= tmp_add
    256 256
    257 257 return SFG([input_op], [output], name=Name(name))
    258
    259
    260 def direct_form_1_iir(
    261 b: Sequence[complex],
    262 a: Sequence[complex],
    263 name: Optional[str] = None,
    264 mult_properties: Optional[Union[Dict[str, int], Dict[str, Dict[str, int]]]] = None,
    265 add_properties: Optional[Union[Dict[str, int], Dict[str, Dict[str, int]]]] = None,
    266 ) -> SFG:
    267 """Generates a direct-form IIR filter of type I with coefficients a and b."""
    268 if len(a) != len(b):
    269 raise ValueError("size of coefficient lists a and b are not the same")
  • The current approach is OK and better to get it in. However, one should consider how zeros are handled and therefore, in the long run, maybe also lift the constraint on same length vectors.

  • Oscar Gustafsson approved this merge request

    approved this merge request

  • Simon Bjurek added 1 commit

    added 1 commit

    • b8f2960e - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Simon Bjurek reset approvals from @oscgu95 by pushing to the branch

    reset approvals from @oscgu95 by pushing to the branch

  • Author Maintainer

    haha accepting your change undid your approval... please accept again :sweat_smile:

  • Oscar Gustafsson approved this merge request

    approved this merge request

  • Simon Bjurek marked this merge request as ready

    marked this merge request as ready

  • Simon Bjurek added 8 commits

    added 8 commits

    • 8f2a3b2d - 1 commit from branch master
    • 6feb66ab - bumped to qtpy6
    • 0fe46553 - work in progress, seems like feed-forward part of direct-form I is working
    • 839d9706 - generators for direct form iir 1 and 2 working, needs automatic tests
    • 4535a14d - removed commented code
    • 78962bef - improved some of the styling
    • 7e2285ae - added docstrings
    • 2ce89054 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Simon Bjurek reset approvals from @oscgu95 by pushing to the branch

    reset approvals from @oscgu95 by pushing to the branch

  • Oscar Gustafsson enabled an automatic merge when all merge checks for 2ce89054 pass

    enabled an automatic merge when all merge checks for 2ce89054 pass

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading