Skip to content
Snippets Groups Projects

Change GraphID numbering to be zero-based

Merged Change GraphID numbering to be zero-based
255-zero-based-graph_id-numbering into master
Merged Hugo Winbladh requested to merge 255-zero-based-graph_id-numbering into master

Closes #255 (closed)

This MR changes the numbering system used for the GraphIDs in SFGs to begin counting from zero instead of one. Backwards compatibility will be broken for old code using hard-coded GraphIDs.

All tests are edited to work with this new numbering system, as well as the code examples in the examples folder.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
examples/firstorderiirfilter.py
115 # "cmul0.0" -> add0
116 # add0 [label=add0 shape=ellipse]
117 # cmul0 -> "cmul0.0"
118 # cmul0 [label=cmul0 shape=ellipse]
119 # "add0.0" -> t0In
120 # t0In [label=t0 shape=square]
121 # "add0.0" -> add1
122 # add1 [label=add1 shape=ellipse]
123 # add0 -> "add0.0"
124 # add0 [label=add0 shape=ellipse]
125 # "add1.0" -> out0
126 # out0 [label=out0 shape=cds]
127 # add1 -> "add1.0"
128 # add1 [label=add1 shape=ellipse]
129 # }
130 #
  • Oscar Gustafsson
    Oscar Gustafsson @oscgu95 ·
    Owner

    @hugwi268 Sorry that you had to endure this. In case there are some more hard-coded graphs, just skip them for now. The next version of sphinx-gallery should be able to capture the graphs automatically (once I get my PR through...).

  • Hugo Winbladh
    Hugo Winbladh @hugwi268 ·
    Author Contributor

    Haha, it's fine. I just ran precedence_graph.source, and formatted it with some vim magic. Took no longer than a minute. But yeah, automating it would be nice for the future :)

  • Please register or sign in to reply
  • Hugo Winbladh changed milestone to %Autumn version

    changed milestone to %Autumn version

  • Hugo Winbladh added Code quality label

    added Code quality label

  • Oscar Gustafsson approved this merge request

    approved this merge request

  • Oscar Gustafsson merged

    merged

    • Please register or sign in to reply