Coupling SFG's

Description of issue:

SFG's should be able to be coupled together with other SFG's. The amount of in/output ports should be preserved when coupling.

Linked Requirements:

( 21 )

Potential Issues:

None

Blockers:

( #8 (closed), #12 (closed) )

Issue Requirements:

1. Given two or more SFG's then these SFG's should be able to be connected in any order if possible. This should return one SFG.
2. The amount of in/output ports should be preserved when coupling, that is do not modify the SFG's when coupling

Comment:

None

added 1 deleted label

added 1 deleted label

mentioned in issue #15 (closed)

mentioned in issue #13 (closed)

added 1 deleted label

assigned to @jacwa448

changed milestone to %Period 2 Kanban

1. As a user given that I have two or more SFGs then I should be able to connect them to create one SFG. The resulting SFG should preserve all operations for each SFG.
2. As a developer given a output from one SFG and a input to another SFG then I should be able to connect the first to the second and return a new SFG.

The user stories looks good to me.

added 1 deleted label and removed 1 deleted label

added Needs testing label and removed 1 deleted label

Added user stories.

added 30m of time spent at 2020-04-20

created branch 14-coupling-sfg-s to address this issue

Started to write some tests and I realized that the base functionality is already present, i.e connecting two SFGs. So I am going to work on some sort of wrapper for it so it becomes a bit easier to use, i.e a shorthand version of it.

added 1h of time spent at 2020-04-20

changed time estimate to 1d 2h

I am not sure what I am supposed to do with this issue now, should I try to make it so that is easier to connect or something else. Currently it looks like this for an example connection between two SFGs, note this is already implemented and works before this issue was started.

sfg = SFG(outputs=[Output(large_operation_tree)])
sfg2 = SFG(inputs=_input, outputs=[Output(large_operation_tree_with_input)])
sfg2.input(0).connect(sfg.output(0), "S100")
sfg3 = SFG(outputs=[Output(sfg2.output(0))])

Any input? @anglo547

If the code you wrote works then I would say that this issue is closed.

closed

added 1 deleted label