feat: add is_carrying_minerals field for Unit class (!5) · Merge requests · Starcraft AI Course / PyCommandCenter · GitLab

Snippets Groups Projects

Merged Dawid Lukasz Abucewicz requested to merge dawab699/pycommandcenter:master into master 5 years ago

1 unresolved thread

Every unit has now a field is_carrying_minerals that will return True if the unit holds minerals, False otherwise.

Edited 5 years ago by Dawid Lukasz Abucewicz

Activity

Dawid Lukasz Abucewicz changed title from feat: add is_carrying_minerals method for Unit class to feat: add is_carrying_minerals field for Unit class 5 years ago

changed title from feat: add is_carrying_minerals method for Unit class to feat: add is_carrying_minerals field for Unit class
Dawid Lukasz Abucewicz changed the description 5 years ago

changed the description
David Bergström @davbe21 started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Dawid Lukasz Abucewicz
Last reply by David Bergström 5 years ago

David Bergström @davbe21 started a thread on the diff 5 years ago

src/Unit.cpp

425	425	BOT_ASSERT(isValid(), "Unit is not valid");
426	426	m_bot->Actions()->UnitCommand(m_unit, sc2::ABILITY_ID::STOP_DANCE);
427	427	}
	428
David Bergström @davbe21 · 5 years ago Owner Ser bra ut! Jag skulle nog inte ha jämfört strängar här, men det borde inte ge någon märkvärd prestandaförsämring. Byt ut alla tabbar mot mellanslag. Please register or sign in to reply

David Bergström @davbe21 started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Dawid Lukasz Abucewicz

David Bergström @davbe21 · 5 years ago

Owner

Lägg till dokumentation i docs också, så att metoden kommer med i dokumentationen. Mer instruktioner kring krav vid merge requests finns här:

http://starcraft-ai-course.gitlab-pages.liu.se/pycommandcenter/contributing.html#contributing

Dawid Lukasz Abucewicz added 1 commit 5 years ago

added 1 commit

c8efaba3 - Apply suggestion to src/Unit.h

Compare with previous version

Dawid Lukasz Abucewicz added 1 commit 5 years ago

added 1 commit

8c6b04cd - Apply suggestion to python-api-src/lib_unit.cpp

Compare with previous version

Dawid Lukasz Abucewicz added 2 commits 5 years ago

added 2 commits

46b7b2d6 - refactor: change some files needed for merge request
ec132ddd - Merge branch 'master' of gitlab.liu.se:dawab699/pycommandcenter

Compare with previous version

David Bergström @davbe21 · 5 years ago

Owner

Bra jobbat! Jag gör mergen nu.

David Bergström mentioned in commit 5 years ago

mentioned in commit 32cfd745

David Bergström merged 5 years ago

merged

Please register or sign in to reply