Refactor reading and storing font and color settings

b_asic/scheduler_gui/main_window.py

@@ -1097,7 +1097,7 @@ class ScheduleMainWindow(QMainWindow, Ui_MainWindow):
 
     def set_latency_color_by_type_name(self, all: bool) -> None:
         """
-        Set latency color based on operation type names
+        Set latency color based on operation type names.
 
         Parameters
         ----------
@@ -1112,17 +1112,17 @@ class ScheduleMainWindow(QMainWindow, Ui_MainWindow):
         # Prompt user to select operation type if not setting color for all types
         if not all:
             used_types = self._schedule.get_used_type_names()
-            type, ok = QInputDialog.getItem(
+            operation_type, ok = QInputDialog.getItem(
                 self, "Select operation type", "Type", used_types, editable=False
             )
         else:
-            type = "all operations"
+            operation_type = "all operations"
             ok = False
 
         # Open a color dialog to get the selected color
         if all or ok:
             color = QColorDialog.getColor(
-                current_color, self, f"Select the color of {type}"
+                current_color, self, f"Select the color of {operation_type}"
             )
 
             # If a valid color is selected, update color settings and graph
@@ -1135,27 +1135,37 @@ class ScheduleMainWindow(QMainWindow, Ui_MainWindow):
                 # Save color settings for each operation type
                 else:
                     self._color_changed_per_type = True
-                    self._changed_operation_colors[type] = color
+                    self._changed_operation_colors[operation_type] = color
                 self.update_color_preferences()
                 self.update_statusbar("Preferences updated")
 
     def update_color_preferences(self) -> None:
         """Update preferences of Latency color per type"""
-        for type in self._schedule.get_used_type_names():
-            if LATENCY_COLOR_TYPE.changed and not self._color_changed_per_type:
-                self._color_per_type[type] = LATENCY_COLOR_TYPE.current_color
-            elif not LATENCY_COLOR_TYPE.changed and not self._color_changed_per_type:
-                self._color_per_type[type] = LATENCY_COLOR_TYPE.DEFAULT
-            elif not LATENCY_COLOR_TYPE.changed and self._color_changed_per_type:
-                if type in self._changed_operation_colors:
-                    self._color_per_type[type] = self._changed_operation_colors[type]
-                else:
-                    self._color_per_type[type] = LATENCY_COLOR_TYPE.DEFAULT
-            else:
-                if type in self._changed_operation_colors:
-                    self._color_per_type[type] = self._changed_operation_colors[type]
-                else:
-                    self._color_per_type[type] = LATENCY_COLOR_TYPE.current_color
+        match (LATENCY_COLOR_TYPE.changed, self._color_changed_per_type):
+            case (True, False):
+                for type_name in self._schedule.get_used_type_names():
+                    self._color_per_type[type_name] = LATENCY_COLOR_TYPE.current_color
+            case (False, False):
+                for type_name in self._schedule.get_used_type_names():
+                    self._color_per_type[type_name] = LATENCY_COLOR_TYPE.DEFAULT
+            case (False, True):
+                for type_name in self._schedule.get_used_type_names():
+                    if type_name in self._changed_operation_colors:
+                        self._color_per_type[type_name] = (
+                            self._changed_operation_colors[type_name]
+                        )
+                    else:
+                        self._color_per_type[type_name] = LATENCY_COLOR_TYPE.DEFAULT
+            case (True, True):
+                for type_name in self._schedule.get_used_type_names():
+                    if type_name in self._changed_operation_colors:
+                        self._color_per_type[type_name] = (
+                            self._changed_operation_colors[type_name]
+                        )
+                    else:
+                        self._color_per_type[type_name] = (
+                            LATENCY_COLOR_TYPE.current_color
+                        )
         self.save_colortype()
 
     def save_colortype(self) -> None:
@@ -1301,7 +1311,7 @@ class ScheduleMainWindow(QMainWindow, Ui_MainWindow):
     def font_color_clicked(self):
         """Select a font color and update preferences"""
         settings = QSettings()
-        color = QColorDialog.getColor(FONT.color, self, "Select Font Color")
+        color = QColorDialog.getColor(FONT.color, self, "Select font color")
         if color.isValid():
             FONT.color = color
             FONT.changed = True
@@ -1442,7 +1452,7 @@ class ScheduleMainWindow(QMainWindow, Ui_MainWindow):
         self, line: QLineEdit, italicbutton: ColorButton, boldbutton: ColorButton
     ) -> None:
         """
-        Update the widgets on the pref dialog to match the current font.
+        Update the widgets on the preference dialog to match the current font.
 
         Parameters
         ----------
@@ -1455,16 +1465,15 @@ class ScheduleMainWindow(QMainWindow, Ui_MainWindow):
         """
         line.setText(str(FONT.size))
 
-        (
+        if FONT.italic:
             italicbutton.set_color(QColor('silver'))
-            if FONT.italic
-            else italicbutton.set_color(QColor('snow'))
-        )
-        (
+        else:
+            italicbutton.set_color(QColor('snow'))
+
+        if FONT.bold:
             boldbutton.set_color(QColor('silver'))
-            if FONT.bold
-            else boldbutton.set_color(QColor('snow'))
-        )
+        else:
+            boldbutton.set_color(QColor('snow'))
 
     @Slot(str)
     def _show_execution_times_for_type(self, type_name):