Skip to content
Snippets Groups Projects

Resolve "Incorrect SFGs do not raise"

Merged Robier Al Kaadi requested to merge 165-incorrect-sfgs-do-not-raise into master
All threads resolved!

Closes #165 (closed) . Modifies 'replace_operation' to handle the case 'sfg.replace_operation(Sink(), "out0")' without raising error. Adds test for "Keep graph_id if possible"

Edited by Robier Al Kaadi

Merge request reports

Pipeline #133571 passed

Pipeline passed for 8fea7b3d on 165-incorrect-sfgs-do-not-raise

Test coverage 79.14% (0.03%) from 8 jobs
Approved by

Merged by Oscar GustafssonOscar Gustafsson 7 months ago (Jul 15, 2024 10:45am UTC)

Merge details

  • Changes merged into master with 7f64ae99 (commits were squashed).
  • Deleted the source branch.

Pipeline #133767 failed

Pipeline failed for 7f64ae99 on master

Test coverage 79.04% (0.03%) from 8 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Robier Al Kaadi resolved all threads

    resolved all threads

  • added 1 commit

    • b76cf1ab - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Oscar Gustafsson approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading