Skip to content
Snippets Groups Projects

Typing and general code cleanup

Merged Oscar Gustafsson requested to merge cleanup into master
Files
3
+ 11
11
@@ -8,9 +8,9 @@ import collections
import collections.abc
import itertools as it
from abc import abstractmethod
from numbers import Number
from typing import (
TYPE_CHECKING,
Any,
Dict,
Iterable,
List,
@@ -33,7 +33,7 @@ from b_asic.graph_component import (
)
from b_asic.port import InputPort, OutputPort, SignalSourceProvider
from b_asic.signal import Signal
from b_asic.types import Num, NumRuntime
from b_asic.types import Num
if TYPE_CHECKING:
# Conditionally imported to avoid circular imports
@@ -592,7 +592,7 @@ class AbstractOperation(Operation, AbstractGraphComponent):
# Import here to avoid circular imports.
from b_asic.core_operations import Addition, Constant
if isinstance(src, NumRuntime):
if isinstance(src, Number):
return Addition(self, Constant(src))
else:
return Addition(self, src)
@@ -602,7 +602,7 @@ class AbstractOperation(Operation, AbstractGraphComponent):
from b_asic.core_operations import Addition, Constant
return Addition(
Constant(src) if isinstance(src, NumRuntime) else src, self
Constant(src) if isinstance(src, Number) else src, self
)
def __sub__(self, src: Union[SignalSourceProvider, Num]) -> "Subtraction":
@@ -610,7 +610,7 @@ class AbstractOperation(Operation, AbstractGraphComponent):
from b_asic.core_operations import Constant, Subtraction
return Subtraction(
self, Constant(src) if isinstance(src, NumRuntime) else src
self, Constant(src) if isinstance(src, Number) else src
)
def __rsub__(self, src: Union[SignalSourceProvider, Num]) -> "Subtraction":
@@ -618,7 +618,7 @@ class AbstractOperation(Operation, AbstractGraphComponent):
from b_asic.core_operations import Constant, Subtraction
return Subtraction(
Constant(src) if isinstance(src, NumRuntime) else src, self
Constant(src) if isinstance(src, Number) else src, self
)
def __mul__(
@@ -632,7 +632,7 @@ class AbstractOperation(Operation, AbstractGraphComponent):
return (
ConstantMultiplication(src, self)
if isinstance(src, NumRuntime)
if isinstance(src, Number)
else Multiplication(self, src)
)
@@ -647,7 +647,7 @@ class AbstractOperation(Operation, AbstractGraphComponent):
return (
ConstantMultiplication(src, self)
if isinstance(src, NumRuntime)
if isinstance(src, Number)
else Multiplication(src, self)
)
@@ -656,7 +656,7 @@ class AbstractOperation(Operation, AbstractGraphComponent):
from b_asic.core_operations import Constant, Division
return Division(
self, Constant(src) if isinstance(src, NumRuntime) else src
self, Constant(src) if isinstance(src, Number) else src
)
def __rtruediv__(
@@ -665,7 +665,7 @@ class AbstractOperation(Operation, AbstractGraphComponent):
# Import here to avoid circular imports.
from b_asic.core_operations import Constant, Division, Reciprocal
if isinstance(src, NumRuntime):
if isinstance(src, Number):
if src == 1:
return Reciprocal(self)
else:
@@ -813,7 +813,7 @@ class AbstractOperation(Operation, AbstractGraphComponent):
"Operation evaluated to incorrect number of outputs"
f" (expected {self.output_count}, got {len(values)})"
)
elif isinstance(values, NumRuntime):
elif isinstance(values, Number):
if self.output_count != 1:
raise RuntimeError(
"Operation evaluated to incorrect number of outputs"
Loading