From 77d961a9c7ee13a6658054e098e897c31beb3cc8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Bergstr=C3=B6m?= <davbe125@student.liu.se>
Date: Wed, 11 Jul 2018 11:05:23 +0200
Subject: [PATCH] Use snake case for methods of IDABot

---
 python-api-src/library.cpp | 4 ++--
 python-api-src/library.h   | 6 ++++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/python-api-src/library.cpp b/python-api-src/library.cpp
index 36356f6..16fa386 100644
--- a/python-api-src/library.cpp
+++ b/python-api-src/library.cpp
@@ -54,8 +54,8 @@ PYBIND11_MODULE(library, m)
         .def(py::init())
         // TODO: The following 3 are CamelCased, but if the name is changed
         // the name used for inheritance in Pyhon stays the same. Weird.
-        .def("OnGameStart", &IDABot::OnGameStart)
-        .def("OnStep", &IDABot::OnStep)
+        .def("on_game_start", &IDABot::OnGameStart)
+        .def("on_step", &IDABot::OnStep)
         .def("get_all_units", &IDABot::GetAllUnits)
         .def("get_my_units", &IDABot::GetMyUnits)
         .def("get_player_race", &IDABot::GetPlayerRace)
diff --git a/python-api-src/library.h b/python-api-src/library.h
index 8c960ce..d6f451f 100644
--- a/python-api-src/library.h
+++ b/python-api-src/library.h
@@ -29,17 +29,19 @@ public:
     using IDABot::IDABot;
     void OnGameStart() override
     {
-        PYBIND11_OVERLOAD(
+        PYBIND11_OVERLOAD_NAME(
             void,
             IDABot,
+            "on_game_start",
             OnGameStart
         );
     }
     void OnStep() override
     {
-        PYBIND11_OVERLOAD(
+        PYBIND11_OVERLOAD_NAME(
             void,
             IDABot,
+            "on_step",
             OnStep
         );
     }
-- 
GitLab