From e6d8f4f81c5430a79916e440bc56cf4c440518b8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Bergstr=C3=B6m?= <davbe125@student.liu.se>
Date: Thu, 5 Jul 2018 14:48:27 +0200
Subject: [PATCH] Always use the prefix is_ for boolean methods
---
python-api-src/lib_base_location.cpp | 2 +-
python-api-src/lib_unit.cpp | 22 +++++++++++-----------
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/python-api-src/lib_base_location.cpp b/python-api-src/lib_base_location.cpp
index 14b881b..2a979b9 100644
--- a/python-api-src/lib_base_location.cpp
+++ b/python-api-src/lib_base_location.cpp
@@ -7,7 +7,7 @@ void define_base_location(py::module & m)
py::class_<BaseLocation>(m, "BaseLocation")
.def_property_readonly("geysers", &BaseLocation::getGeysers)
.def_property_readonly("minerals", &BaseLocation::getMinerals)
- .def_property_readonly("start_location", &BaseLocation::isStartLocation)
+ .def_property_readonly("is_start_location", &BaseLocation::isStartLocation)
.def_property_readonly("depot_position", &BaseLocation::getDepotPosition)
.def_property_readonly("position", &BaseLocation::getPosition)
.def("get_ground_distance", py::overload_cast<const CCPosition &>(&BaseLocation::getGroundDistance, py::const_))
diff --git a/python-api-src/lib_unit.cpp b/python-api-src/lib_unit.cpp
index fe68d9f..11974bb 100644
--- a/python-api-src/lib_unit.cpp
+++ b/python-api-src/lib_unit.cpp
@@ -15,17 +15,17 @@ void define_unit(py::module & m)
.def_property_readonly("id", &Unit::getID)
.def_property_readonly("build_percentage", &Unit::getBuildPercentage)
.def_property_readonly("weapon_cooldown", &Unit::getWeaponCooldown)
- .def_property_readonly("completed", &Unit::isCompleted)
- .def_property_readonly("being_constructed", &Unit::isBeingConstructed)
- .def_property_readonly("cloaked", &Unit::isCloaked)
- .def_property_readonly("flying", &Unit::isFlying)
- .def_property_readonly("alive", &Unit::isAlive)
- .def_property_readonly("powered", &Unit::isPowered)
- .def_property_readonly("idle", &Unit::isIdle)
- .def_property_readonly("burrowed", &Unit::isBurrowed)
- .def_property_readonly("valid", &Unit::isValid)
- .def_property_readonly("training", &Unit::isTraining)
- .def_property_readonly("constructing", &Unit::isConstructing)
+ .def_property_readonly("is_completed", &Unit::isCompleted)
+ .def_property_readonly("is_being_constructed", &Unit::isBeingConstructed)
+ .def_property_readonly("is_cloaked", &Unit::isCloaked)
+ .def_property_readonly("is_flying", &Unit::isFlying)
+ .def_property_readonly("is_alive", &Unit::isAlive)
+ .def_property_readonly("is_powered", &Unit::isPowered)
+ .def_property_readonly("is_idle", &Unit::isIdle)
+ .def_property_readonly("is_burrowed", &Unit::isBurrowed)
+ .def_property_readonly("is_valid", &Unit::isValid)
+ .def_property_readonly("is_training", &Unit::isTraining)
+ .def_property_readonly("is_constructing", &Unit::isConstructing)
.def("stop", &Unit::stop)
.def("attack_unit", &Unit::attackUnit)
.def("attack_move", &Unit::attackMove)
--
GitLab